exec, query: factor out common parameter handling helpers#23
Closed
robx wants to merge 1 commit into
Closed
Conversation
There were two identical copies each of the parameter mangling code.
This was referenced Jul 4, 2022
Collaborator
Yes. But looking at the code, I want to clean up it further, and it's easier to me to do it than try to explain. So I'll do it at some time in the future (around when GHC-9.4 is released the latest). |
Contributor
Author
Did you get a chance to look at this? |
Collaborator
|
Sorry for huge delay. I finally made some time to look after In meantime I'll drop GHC-7 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two identical copies each of the parameter mangling code.
First change from #22.